SubSonicRepository Insert bug

Hello!

I think I found a bug in the repository insert when not using autoincrement-pk. The query will never execute unless its autoincrement.

My fix was just to move the ExecuteScalar-statement to make sure its run. I dont know if its the correct way though!

Index: SubSonicRepository.cs
===================================================================
--- SubSonicRepository.cs    (revision 453)
+++ SubSonicRepository.cs    (working copy)
@@ -206,13 +206,16 @@
             
             int result = 0;
             QueryCommand cmd = ActiveHelper<T>.GetInsertCommand(item, userName);
+
             TableSchema.Table schema = item.GetSchema();
             if (schema.PrimaryKey != null)
             {
+                object qResult = DataService.ExecuteScalar(cmd);
+
                 if(schema.PrimaryKey.AutoIncrement)
                 {
-                    object qResult = DataService.ExecuteScalar(cmd);
                     item.SetColumnValue(schema.PrimaryKey.ColumnName, qResult);
+
                     if(qResult != null)
                         int.TryParse(qResult.ToString(), out result);
                 }

Thanks for this - i'll see what I can do here; not sure what you've added will solve the issue but it's close ;).

I added an else in there to make sure it gets executed - thanks for the catch!

Hello

There still is a bug in the insert.

If you have a table with a Primary Key thats NOT autoincremented, it wont run the insert.

I made this change

            if (schema.PrimaryKey != null)
            {

                object qResult = DataService.ExecuteScalar(cmd); // Moved this line out of the AutoIncrement test

                if(schema.PrimaryKey.AutoIncrement)
                {
                    item.SetColumnValue(schema.PrimaryKey.ColumnName, qResult);
                    if(qResult != null)
                        int.TryParse(qResult.ToString(), out result);
                }
            }
            else
            {
                result = DataService.ExecuteQuery(cmd);
            }

Im using the newest RC1 download today.

BR

Søren

Did you check the version from SVN

Hi Soren - this won't fix the issue. What I did was to move your "else" statement one level deeper, and that fixed the problem. Your check here will run the insert if there's no PK - which I also added :)